-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus block selection button only in navigation mode #60207
Conversation
Size Change: +5 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
if ( editorMode === 'navigation' ) { | ||
ref.current.focus(); | ||
speak( label ); | ||
} | ||
}, [ label, editorMode ] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this. It seems the core issue is that focusing this shouldn't automatically close the inserter. We're going to need to be able to have focus on the zoom-out mode toolbar and also stay in zoom-out mode. For example:
- Insert a new pattern
- Click on the revealed pattern toolbar to move the pattern up/down.
- Pattern inserter is closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment/TODO to remove this check once we're able to have focus on the zoom out view toolbar and the inserter stays open?
I'll add the comment in a PR that removes the block name and brings over the drag button. |
What?
Closes #59741
Why?
To avoid flickering UI while assembling a page from multiple patterns.
To keep the UI behaviour consistent between editor modes.
How?
Manually place focus on the block selection button component only in navigation mode.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
inserter-stays-open.mp4